-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add native driver extensions #92
base: master
Are you sure you want to change the base?
Conversation
Hmm, should these be extensions or direct dependencies? |
This is not unlike how Rasters (@rafaqz) does it? IIRC Rasters even dropped ArchGDAL as a direct dep. Besides, direct deps on all seems unncessarily slow to me, and I fear none of the default drivers have enormous improvements over GDAL (as of now). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Love to see this :)
Yes not depending on all of them is probably better, for load time and dependency weight of projects building on this
src/GeoDataFrames.jl
Outdated
using DataAPI | ||
using Reexport | ||
|
||
@reexport using Extents | ||
@reexport using GeoFormatTypes | ||
|
||
include("exports.jl") | ||
include("sources.jl") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This could be drivers.jl
be use you suffix with XXDriver
? Or `backends? I want to change this from sources in Rasters anyway
Hmm, would one load JuliaGeo.jl just to get all backends then? That is probably not a bad solution, and still lets users pick and choose. |
Can we just call it Geo.jl ? |
Not sure if that's acceptable for registration. |
Including Julia in a package name is against the rules. Why is Geo not ok? |
Fair point about Julia in the name. I assumed geo is too short, but let's try? |
We can ask for an override on the short name, like CSV.jl |
Enables reading/writing using GeoJSON, GeoParquet, Shapefile and FlatGeobuf extensions. In the future also GeoArrow.
Requires doc update, and some iteration on the interface, like passing driver specific options.