Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add native driver extensions #92

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Add native driver extensions #92

wants to merge 4 commits into from

Conversation

evetion
Copy link
Owner

@evetion evetion commented Nov 20, 2024

Enables reading/writing using GeoJSON, GeoParquet, Shapefile and FlatGeobuf extensions. In the future also GeoArrow.

Requires doc update, and some iteration on the interface, like passing driver specific options.

@evetion evetion requested a review from visr November 20, 2024 09:51
@asinghvi17
Copy link
Contributor

Hmm, should these be extensions or direct dependencies?

@evetion
Copy link
Owner Author

evetion commented Nov 20, 2024

Hmm, should these be extensions or direct dependencies?

This is not unlike how Rasters (@rafaqz) does it? IIRC Rasters even dropped ArchGDAL as a direct dep. Besides, direct deps on all seems unncessarily slow to me, and I fear none of the default drivers have enormous improvements over GDAL (as of now).

Copy link
Contributor

@rafaqz rafaqz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love to see this :)

Yes not depending on all of them is probably better, for load time and dependency weight of projects building on this

using DataAPI
using Reexport

@reexport using Extents
@reexport using GeoFormatTypes

include("exports.jl")
include("sources.jl")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This could be drivers.jl be use you suffix with XXDriver ? Or `backends? I want to change this from sources in Rasters anyway

@asinghvi17
Copy link
Contributor

Hmm, would one load JuliaGeo.jl just to get all backends then? That is probably not a bad solution, and still lets users pick and choose.

@rafaqz
Copy link
Contributor

rafaqz commented Nov 20, 2024

Can we just call it Geo.jl ?

@evetion
Copy link
Owner Author

evetion commented Nov 21, 2024

Can we just call it Geo.jl ?

Not sure if that's acceptable for registration.

@rafaqz
Copy link
Contributor

rafaqz commented Nov 21, 2024

Including Julia in a package name is against the rules.

Why is Geo not ok?

@evetion
Copy link
Owner Author

evetion commented Nov 21, 2024

Fair point about Julia in the name. I assumed geo is too short, but let's try?

@rafaqz
Copy link
Contributor

rafaqz commented Nov 21, 2024

We can ask for an override on the short name, like CSV.jl

Project.toml Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants