Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "I'm feeling lucky" mode #99

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

TomVarga
Copy link
Contributor

When this option is on, whenever you open VLSub it'll first try to find a sub by hash if not found then by name then download and load it basically a one button feature.

I think this is a pretty good feature, but the implementation could probably be a bit better. I looked into closing the GUI on a timer when the option is enabled, but that does not seem possible. Having this feature be a separate option in the view menu could also be another approach, but I'm not sure that's possible either from a single extension ( I think that is however possible for interfaces in VLC ).

Please let me know what you think!

TomVarga added 2 commits June 23, 2015 16:44
	when this option is on, whenever you open VLSub it'll
	first try to find a sub by hash
	if not found then by name
		then download and load it
	basically a one button feature
@waldyrious
Copy link

  1. I don't think "I'm feeling lucky type behavior" sounds right. Maybe "I'm feeling lucky mode" or something like that.

  2. What does this do if it finds more than one subtitle by hash (or by name)? How does it choose among the options? By number of downloads? By subtitle rating? By uploader account type? I feel any of these would be better than for example picking the first one, or picking randomly.

@TomVarga
Copy link
Contributor Author

Right, "I'm feeling lucky mode" probably describes this better.

Currently it picks the first from the list. From my experience that has not been that bad to begin with, but I see what you mean by picking the "lucky" subtitle from the available list.

@TomVarga TomVarga changed the title Add "I'm feeling lucky" type behavior Add "I'm feeling lucky" mode Jun 29, 2015
@waldyrious
Copy link

I'd suggest using a weighted sum of rating, downloads, uploader type (admin, trusted, whatever), with decreasing weights from the former to the latter. Does that make sense?

@TomVarga
Copy link
Contributor Author

Yeah that does make sense, however now that I've actually looked into the OpenSubtitles API it seems like the returned subtitle array is already sorted by seencount descending, so the first is already the most popular one. I'm not convinced that trying to work out a weighting system would be that much better.

@waldyrious
Copy link

I suspected they already did some internal sorting. In that case, I agree, let's not reinvent the wheel and go with the first one. This would be a great functionality, 👍 :)

@sherazfn
Copy link

sherazfn commented Nov 3, 2015

Hi,

This sounds great. How do I access this feature? I think I have VLSUB 0.9.13

Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants