Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ NEW: Add math directive #13

Merged
merged 4 commits into from
Nov 12, 2021
Merged

✨ NEW: Add math directive #13

merged 4 commits into from
Nov 12, 2021

Conversation

rowanc1
Copy link
Member

@rowanc1 rowanc1 commented Aug 4, 2021

Introduce a math directive:

```{math}
:label: my_label
w_{t+1} = (1 + r_{t+1}) s(w_t) + y_{t+1}
```

Development:

  • Better typing for options

Leaving out of this PR:

  • Actually dealing with the labels

@rowanc1 rowanc1 mentioned this pull request Aug 4, 2021
9 tasks
@chrisjsewell
Copy link
Member

This obviously ties in to executablebooks/markdown-it-amsmath#3, i.e. I think here there needs to be a consistent way to have this math rendered by e.g. katex, within the markdown-it parse/render process

@rowanc1
Copy link
Member Author

rowanc1 commented Aug 5, 2021

This will need another pass to reconcile with the labeling and the inline math renderer. Once we get it in, can do another pass on that before releasing.

@rowanc1
Copy link
Member Author

rowanc1 commented Nov 11, 2021

Let's get this in, we can do any reconciliation with other math nodes later, the only change would be to the options which is in another branch.

Copy link
Member

@chrisjsewell chrisjsewell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Again this just needs fixing of the merge conflict

* Better typing for options
src/index.ts Outdated Show resolved Hide resolved
src/index.ts Outdated Show resolved Hide resolved
@chrisjsewell chrisjsewell changed the title Math directive with label ✨ NEW: Add math directive Nov 12, 2021
@chrisjsewell chrisjsewell merged commit eac2cb6 into main Nov 12, 2021
@chrisjsewell chrisjsewell deleted the feat/math branch November 12, 2021 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants