Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aggregate RAM usage by parent process #2296

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

andrewr-dev
Copy link
Contributor

Proposal to fix the following with a new Combine processes option:
Fixes: #2099
Fixes: #2162

@exelban
Copy link
Owner

exelban commented Jan 1, 2025

hi. Thanks for your contribution, at first look it looks fine. But I will need some time to check how it works and if all cases are covered. Will back with feedback later.

PS: please ping me in case I will not provide any feedback in 7 days

@andrewr-dev andrewr-dev force-pushed the combine_processes_option branch from c543880 to 593cc10 Compare January 4, 2025 19:11
@exelban
Copy link
Owner

exelban commented Jan 11, 2025

Zrzut ekranu 2025-01-11 o 18 21 43

something is totally off

@andrewr-dev
Copy link
Contributor Author

Code was displaying resident_size
Changing it to display phys_footprint seems like a closer match to the Memory column in Activity Monitor

@exelban
Copy link
Owner

exelban commented Jan 19, 2025

Hi, are you at least run and check this PR?
The second time it's totally of from what activity monitor shows.

Zrzut ekranu 2025-01-19 o 12 54 28

@andrewr-dev
Copy link
Contributor Author

The previous screenshot is showing individual process usage. You need to look at the process hierarchy, eg. lldb-rpc-server is a child process of XCode so the memory usage is added together. Similarly, all the Safari processes are added together and grouped under Safari.
The InferenceProviderService process is owned by another user (_modelmanagerd) and the memory usage for this process not shown.

@andrewr-dev
Copy link
Contributor Author

Also I changed a line in Modules/RAM/popup.swift to correct an existing issue with the way GB is displayed (changed GB RAM to use powers of 2 rather than decimal). The screenshot seems to be missing this minor correction.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature request] Aggregate RAM usage by process RAM usage: total usage per main process
2 participants