-
-
Notifications
You must be signed in to change notification settings - Fork 161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
roman-numerals: add generator and regenerate tests #734
Conversation
This PR touches files which potentially affect the outcome of the tests of an exercise. This will cause all students' solutions to affected exercises to be re-tested. If this PR does not affect the result of the test (or, for example, adds an edge case that is not worth rerunning all tests for), please add the following to the merge-commit message which will stops student's tests from re-running. Please copy-paste to avoid typos.
For more information, refer to the documentation. If you are unsure whether to add the message or not, please ping |
adbeca9
to
5146d9f
Compare
5146d9f
to
a3d84c0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Extra line at the end of the tpl file.
- Unsynced .toml file
- .problem-specifications directory is included
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The tests file needs to be regenerated with the new names.
bcc7feb
to
f9f6e6f
Compare
Updated! |
[no important files changed]
f9f6e6f
to
6125bec
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In case you are wondering why I'm not merging after approval. I'll typically only merge trivial PRs, everything else I prefer to let the OP merge whenever they want.
Yes that is actually the etiquette most of exercism adheres to 👍 |
Should be merged after #728 is merged