Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

roman-numerals: add generator and regenerate tests #734

Merged
merged 1 commit into from
Jan 13, 2025

Conversation

ErikSchierboom
Copy link
Member

@ErikSchierboom ErikSchierboom commented Jan 11, 2025

Should be merged after #728 is merged

Copy link
Contributor

This PR touches files which potentially affect the outcome of the tests of an exercise. This will cause all students' solutions to affected exercises to be re-tested.

If this PR does not affect the result of the test (or, for example, adds an edge case that is not worth rerunning all tests for), please add the following to the merge-commit message which will stops student's tests from re-running. Please copy-paste to avoid typos.

[no important files changed]

For more information, refer to the documentation. If you are unsure whether to add the message or not, please ping @exercism/maintainers-admin in a comment. Thank you!

Copy link
Member

@tasxatzial tasxatzial left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Extra line at the end of the tpl file.
  • Unsynced .toml file
  • .problem-specifications directory is included

Copy link
Member

@tasxatzial tasxatzial left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tests file needs to be regenerated with the new names.

exercises/practice/roman-numerals/.meta/generator.tpl Outdated Show resolved Hide resolved
@ErikSchierboom ErikSchierboom force-pushed the roman-numerals-template branch 3 times, most recently from bcc7feb to f9f6e6f Compare January 12, 2025 15:55
@ErikSchierboom
Copy link
Member Author

Updated!

@ErikSchierboom ErikSchierboom force-pushed the roman-numerals-template branch from f9f6e6f to 6125bec Compare January 13, 2025 07:39
Copy link
Member

@tasxatzial tasxatzial left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In case you are wondering why I'm not merging after approval. I'll typically only merge trivial PRs, everything else I prefer to let the OP merge whenever they want.

@ErikSchierboom
Copy link
Member Author

Yes that is actually the etiquette most of exercism adheres to 👍

@ErikSchierboom ErikSchierboom merged commit ecaef71 into main Jan 13, 2025
2 checks passed
@ErikSchierboom ErikSchierboom deleted the roman-numerals-template branch January 13, 2025 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants