-
-
Notifications
You must be signed in to change notification settings - Fork 161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add high-scores
exercise
#743
Conversation
This is one of the exercises where the terminology from canonical data conflicts with Clojure terminology. There's an open issue about it (no discussion, though) because there have complaints that it's confusing. See #671 To sum up, scores_test_1 and personal-top-three_test_1 both use the word "list", but the actual test uses vectors. One option is to change their descriptions to refer to vectors. Another option is to do nothing. But in any case, I'm always adding an append file because the description also uses lists. |
7d391fb
to
b8e4bd6
Compare
@tasxatzial I've converted the template and tests to use a list |
b8e4bd6
to
292ae56
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Given that we normally use vectors to store data, lists are my least preferred option. But that's ok, it's a simple exercise, I guess it's ok to use lists.
I thought that it was perhaps good to also have students work with lists occasionally. I you feel that vectors would be better I'm happy to revert and add the append file. |
I agree 100%. Lets go with lists. |
Co-authored-by: Anastasios Chatzialexiou <[email protected]>
Co-authored-by: Anastasios Chatzialexiou <[email protected]>
Co-authored-by: Anastasios Chatzialexiou <[email protected]>
Co-authored-by: Anastasios Chatzialexiou <[email protected]>
Co-authored-by: Anastasios Chatzialexiou <[email protected]>
No description provided.