Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add high-scores exercise #743

Merged
merged 7 commits into from
Jan 14, 2025
Merged

Add high-scores exercise #743

merged 7 commits into from
Jan 14, 2025

Conversation

ErikSchierboom
Copy link
Member

No description provided.

@tasxatzial
Copy link
Member

tasxatzial commented Jan 14, 2025

This is one of the exercises where the terminology from canonical data conflicts with Clojure terminology. There's an open issue about it (no discussion, though) because there have complaints that it's confusing. See #671

To sum up, scores_test_1 and personal-top-three_test_1 both use the word "list", but the actual test uses vectors. One option is to change their descriptions to refer to vectors. Another option is to do nothing. But in any case, I'm always adding an append file because the description also uses lists.
This one here can be copied as is:https://github.com/exercism/clojure/blob/main/exercises/practice/sublist/.docs/instructions.append.md

@ErikSchierboom
Copy link
Member Author

@tasxatzial I've converted the template and tests to use a list

Copy link
Member

@tasxatzial tasxatzial left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given that we normally use vectors to store data, lists are my least preferred option. But that's ok, it's a simple exercise, I guess it's ok to use lists.

config.json Outdated Show resolved Hide resolved
exercises/practice/high-scores/src/high_scores.clj Outdated Show resolved Hide resolved
exercises/practice/high-scores/src/high_scores.clj Outdated Show resolved Hide resolved
exercises/practice/high-scores/src/high_scores.clj Outdated Show resolved Hide resolved
exercises/practice/high-scores/src/high_scores.clj Outdated Show resolved Hide resolved
exercises/practice/high-scores/project.edn Outdated Show resolved Hide resolved
@ErikSchierboom
Copy link
Member Author

I thought that it was perhaps good to also have students work with lists occasionally. I you feel that vectors would be better I'm happy to revert and add the append file.

@tasxatzial
Copy link
Member

I agree 100%. Lets go with lists.

@ErikSchierboom ErikSchierboom merged commit 63b4447 into main Jan 14, 2025
2 checks passed
@ErikSchierboom ErikSchierboom deleted the high-scores branch January 14, 2025 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants