Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

triangle: update to latest #746

Merged
merged 4 commits into from
Jan 13, 2025
Merged

triangle: update to latest #746

merged 4 commits into from
Jan 13, 2025

Conversation

ErikSchierboom
Copy link
Member

[no important files changed]

[no important files changed]
Copy link
Contributor

This PR touches files which potentially affect the outcome of the tests of an exercise. This will cause all students' solutions to affected exercises to be re-tested.

If this PR does not affect the result of the test (or, for example, adds an edge case that is not worth rerunning all tests for), please add the following to the merge-commit message which will stops student's tests from re-running. Please copy-paste to avoid typos.

[no important files changed]

For more information, refer to the documentation. If you are unsure whether to add the message or not, please ping @exercism/maintainers-admin in a comment. Thank you!

Copy link
Member

@tasxatzial tasxatzial left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The functions take 3 arguments. Also it's good to mention what the function returns. The Clojure docs do the same (mostly).

exercises/practice/triangle/src/triangle.clj Outdated Show resolved Hide resolved
exercises/practice/triangle/src/triangle.clj Outdated Show resolved Hide resolved
exercises/practice/triangle/src/triangle.clj Outdated Show resolved Hide resolved
@ErikSchierboom ErikSchierboom merged commit eee3090 into main Jan 13, 2025
2 checks passed
@ErikSchierboom ErikSchierboom deleted the triangle branch January 13, 2025 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants