Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add knapsack exercise #707

Merged
merged 2 commits into from
Jan 25, 2025
Merged

Add knapsack exercise #707

merged 2 commits into from
Jan 25, 2025

Conversation

JohnMertz
Copy link
Contributor

@JohnMertz JohnMertz commented Jan 18, 2025

This is my first crack at trying to contribute an exercise, so please feel free to point me in the right direction if I've done something incorrectly. I read the docs and tried to make the commit as similar as possible to other exercise PRs.

If all goes well, I'll be happy to create more, for want of having any more to do! :)

The discussion is located here.

Copy link

Hello. Thanks for opening a PR on Exercism 🙂

We ask that all changes to Exercism are discussed on our Community Forum before being opened on GitHub. To enforce this, we automatically close all PRs that are submitted. That doesn't mean your PR is rejected but that we want the initial discussion about it to happen on our forum where a wide range of key contributors across the Exercism ecosystem can weigh in.

You can use this link&category=perl5 ) to copy this into a new topic on the forum. If we decide the PR is appropriate, we'll reopen it and continue with it, so please don't delete your local branch.

If you're interested in learning more about this auto-responder, please read this blog post.


Note: If this PR has been pre-approved, please link back to this PR on the forum thread and a maintainer or staff member will reopen it.

@github-actions github-actions bot closed this Jan 18, 2025
@kotp kotp reopened this Jan 18, 2025
@kotp kotp requested review from m-dango and a team January 18, 2025 00:46
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't believe the empty cpanfile is necessary, but other than that looks good to me!

This is the only exercise that would have this file (empty or not).
@kotp kotp merged commit e338145 into exercism:main Jan 25, 2025
19 checks passed
@kotp
Copy link
Member

kotp commented Jan 25, 2025

Thank you @JohnMertz . I removed the CPANFILE that was empty and would have been the only exercise with it. In case you notice it is gone!

@JohnMertz
Copy link
Contributor Author

Thanks! The CPANFILE was an accidental confusion. It appears to get generated by the exercise-gen.pl script (or maybe this is just a consequence of my plenv configuration). I'll make sure to omit this in future exercise commits.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants