binary-search: use vectors instead of lists for the sorted-data #324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
also, return #f when target not found, which is more in line with how the exercise is implemented in other tracks (Common Lisp, Scheme) and `vector-binary-search` in srfi-43 https://docs.racket-lang.org/srfi/srfi-std/srfi-43.html#vector-binary-search
|
Thanks, I’ll review this weekend and get back to you. |
|
Looks good. I'd suggest adding yourself as a contributor in the exercise's config file since the test suite and example changed a lot. |
BNAndras
approved these changes
Dec 29, 2023
|
I don't know why the build is failing; The the last commit is so insignificant, I don't see how it could cause the failure. The previous commit passed all the checks. |
|
Agreed. Giving it one last shot and then merging it. |
BNAndras
added
x:action/improve
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additionally, I decided to go ahead and make it return
#fwhen the target is not found instead of throwing an error, which is more in line with how the exercise is implemented in other tracks (Common Lisp, Scheme) andvector-binary-searchin srfi-43: https://docs.racket-lang.org/srfi/srfi-std/srfi-43.html#vector-binary-searchIf this later change is not ok, I will revert it.
addresses #323