Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update binary search #369

Merged
merged 4 commits into from
Apr 9, 2024
Merged

Conversation

BNAndras
Copy link
Member

@BNAndras BNAndras commented Apr 7, 2024

I've added an instructions append to clarify that sorted vectors are being used instead of lists. I've also replaced references to arrays in the test suite. I did some minor formatting and converted a few of the (test-eqv ... #f) tests to the simpler (test-false ...) tests

@BNAndras BNAndras added x:action/proofread Proofread text x:type/docs Work on Documentation x:rep/tiny Tiny amount of reputation labels Apr 7, 2024
Copy link

github-actions bot commented Apr 7, 2024

This PR touches files which potentially affect the outcome of the tests of an exercise. This will cause all students' solutions to affected exercises to be re-tested.

If this PR does not affect the result of the test (or, for example, adds an edge case that is not worth rerunning all tests for), please add the following to the merge-commit message which will stops student's tests from re-running. Please copy-paste to avoid typos.

[no important files changed]

For more information, refer to the documentation. If you are unsure whether to add the message or not, please ping @exercism/maintainers-admin in a comment. Thank you!

@BNAndras BNAndras requested a review from ErikSchierboom April 7, 2024 04:45
@BNAndras BNAndras merged commit f269694 into exercism:main Apr 9, 2024
8 checks passed
@BNAndras BNAndras deleted the update-binary-search branch April 9, 2024 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
x:action/proofread Proofread text x:rep/tiny Tiny amount of reputation x:type/docs Work on Documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants