Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken zone flag for sks update command #662

Merged

Conversation

kobajagi
Copy link
Contributor

@kobajagi kobajagi commented Jan 20, 2025

Description

Adds missing switchClientZoneV3 call in sksUpdateCmd.

Checklist

(For exoscale contributors)

  • Changelog updated (under Unreleased block)
  • Testing

Testing

$ exo c sks update 836d52e7-3ce6-4af0-853f-c23253320d38 --name mycluster2 -z at-vie-1
error: "836d52e7-3ce6-4af0-853f-c23253320d38" not found in ListSKSClustersResponse: Not Found

$ go run . c sks update 836d52e7-3ce6-4af0-853f-c23253320d38 --name mycluster2 -z at-vie-1
 ✔ Updating SKS cluster "836d52e7-3ce6-4af0-853f-c23253320d38"... 21s
┼───────────────┼──────────────────────────────────────────────────────────────────┼
│  SKS CLUSTER  │                                                                  │
┼───────────────┼──────────────────────────────────────────────────────────────────┼
│ ID            │ 836d52e7-3ce6-4af0-853f-c23253320d38                             │
│ Name          │ mycluster2                                                       │
│ Description   │                                                                  │
│ Zone          │ at-vie-1                                                         │
│ Creation Date │ 2025-01-20 11:36:44 +0000 UTC                                    │
│ Auto-upgrade  │ false                                                            │
│ Endpoint      │ https://836d52e7-3ce6-4af0-853f-c23253320d38.sks-at-vie-1.exo.io │
│ Version       │ 1.31.3                                                           │
│ Service Level │ pro                                                              │
│ CNI           │ calico                                                           │
│ Add-Ons       │ exoscale-cloud-controller                                        │
│               │ metrics-server                                                   │
│ State         │ running                                                          │
│ Labels        │ n/a                                                              │
│ Nodepools     │ 95a543b6-6b50-4469-9f4b-26b99c545e9f | mycluster                 │
┼───────────────┼──────────────────────────────────────────────────────────────────┼

@kobajagi kobajagi merged commit 549b663 into master Jan 20, 2025
1 check passed
@kobajagi kobajagi deleted the predrag/sc-117081/cli-zone-flag-ignored-in-sks-update branch January 20, 2025 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants