Reverted changes as need to think more on this

Signed-off-by: expani <[email protected]>
expani · Dec 27, 2024 · 598b9af · 598b9af
1 parent 54ac23e
commit 598b9af
Showing 1 changed file with 4 additions and 11 deletions.
diff --git a/server/src/main/java/org/opensearch/index/search/comparators/UnsignedLongComparator.java b/server/src/main/java/org/opensearch/index/search/comparators/UnsignedLongComparator.java
@@ -53,12 +53,12 @@ public LeafFieldComparator getLeafComparator(LeafReaderContext context) throws I
 
     @Override
     protected long missingValueAsComparableLong() {
-        return unSignedToSignedLong(missingValue);
+        return missingValue.longValue();
     }
 
     @Override
     protected long sortableBytesToLong(byte[] bytes) {
-        return unSignedToSignedLong(NumericUtils.sortableBytesToBigInt(bytes, 0, BigIntegerPoint.BYTES));
+        return NumericUtils.sortableBytesToBigInt(bytes, 0, BigIntegerPoint.BYTES).longValue();
     }
 
     /** Leaf comparator for {@link UnsignedLongComparator} that provides skipping functionality */
@@ -100,19 +100,12 @@ public void copy(int slot, int doc) throws IOException {
 
         @Override
         protected long bottomAsComparableLong() {
-            return unSignedToSignedLong(bottom);
+            return bottom.longValue();
         }
 
         @Override
         protected long topAsComparableLong() {
-            return unSignedToSignedLong(topValue);
+            return topValue.longValue();
         }
     }
-
-    /**
-     * Converts unsigned long to signed the same as java.lang.{@link Long#compareUnsigned(long, long)}
-     */
-    private static long unSignedToSignedLong(BigInteger value) {
-        return value.longValue() + Long.MIN_VALUE;
-    }
 }