Obj's with tga textures don't get their textures displayed

[Git-i]

Describe the bug
Obj imports don't support .tga textures

To Reproduce
Steps to reproduce the behavior:

1. Open any obj file with a .tga texture

Expected behavior
The file loads and the texture is displayed

System Information:

• OS: Windows 11
• GPU and GPU driver: NVIDIA Geforce RTX 3050M

F3D Information
F3D 2.3.0

F3D - A fast and minimalist 3D viewer
Version: 2.3.0.
Build date: 2024-01-21 19:20:59.
Build system: Windows 64-bits.
Compiler: MSVC 19.37.32826.1.
External rendering module: ON.
Raytracing module: OFF.
VTK version: 9.3.0-1702-geb008dfe7b (date: 20240111).
Copyright (C) 2019-2021 Kitware SAS.
Copyright (C) 2021-2024 Michael Migliore, Mathieu Westphal.
License BSD-3-Clause.
By Michael Migliore, Mathieu Westphal and Joachim Pouderoux.

[mwestphal]

vtkOBJImporter indeed does not support TGA texture for now. It would be nice to add and should not be that hard. wdyt @Meakk ?

[Meakk]

Isn't it using the image factory?

[Meakk]

The problem is indeed in VTK. In the file IO/Import/vtkOBJImporterInternals.cxx, function bindTexturedPolydataToRenderWindow, a bunch of image formats are tested (TIFF, PNG, JPG, BMP), but it should be changed to use the image reader factory.

e.g.

auto reader = vtkSmartPointer<vtkImageReader2>::Take(
    vtkImageReader2Factory::CreateImageReader2(textureFilename.c_str()));

  if (reader)
  {
    reader->SetFileName(fullPath.c_str());
    reader->Update();
    vtkSmartPointer<vtkTexture> vtk_texture = vtkSmartPointer<vtkTexture>::New();
    vtk_texture->AddInputConnection(reader->GetOutputPort());
    actor->SetTexture(vtk_texture);
    knownTextures[textureFilename] = vtk_texture;
  }

[mwestphal]

Nice find, should be simple indeed.

[gapry]

I'd like to work on this issue. Could you please assign it to me?

[Meakk]

Nice. Thanks!

[mwestphal]

@gapry any news on this ?

[gapry]

@mwestphal Sorry, I need more time, I anticipate having the first patch ready between the 15th and 17th of this month.

[mwestphal]

No worries!

[gapry]

I'm sorry, I haven't finished yet.

But I have some process, please see the PR: #1719

[mwestphal]

If you have any question on how to fix this please reachout and ask :)

[mwestphal]

Open to contribution for now :)