Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
as detailed here, PNGs fail to hash when passed to the /h/hash endpoint. PNG hashes work via the threatexchange CLI because it is guaranteed that the contents are flushed before hashing occurs:
but when
filename
is set in thewith
block, this is not the case for PNGs. manually callflush
to fix thishttps://discuss.python.org/t/should-tempfile-namedtemporaryfile-automatically-flush-the-buffer/17388 - in python 3.13 (we are on 3.11) there is a
delete_on_close
that we could use but deletion isn't guaranteedTest Plan
Confirmed that the endpoint can now hash PNGs with
flush
added