Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(seo): docs breadcrumb structured data should use JSON-LD and filter unliked categories #10888

Merged
merged 2 commits into from
Feb 7, 2025

Conversation

johnnyreilly
Copy link
Contributor

@johnnyreilly johnnyreilly commented Feb 1, 2025

Pre-flight checklist

There seem to be some failing tests, but as far as I can tell these are not related to my changes.

Motivation

To have the structured data approach favoured by Google (JSON-LD) and also consistency.

Test Plan

screenshot of rich results

screenshot of AHREFs

Test links

Deploy preview: https://deploy-preview-10888--docusaurus-2.netlify.app/docs/configuration/

Related issues/PRs

#9319

Copy link

netlify bot commented Feb 1, 2025

[V2]

Name Link
🔨 Latest commit 428988d
🔍 Latest deploy log https://app.netlify.com/sites/docusaurus-2/deploys/67a64816c6e7790008e87ac5
😎 Deploy Preview https://deploy-preview-10888--docusaurus-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

github-actions bot commented Feb 1, 2025

⚡️ Lighthouse report for the deploy preview of this PR

URL Performance Accessibility Best Practices SEO Report
/ 🟠 70 🟢 98 🟢 96 🟢 100 Report
/docs/installation 🟠 53 🟢 97 🟢 100 🟢 100 Report
/docs/category/getting-started 🟠 71 🟢 100 🟢 100 🟠 86 Report
/blog 🟠 62 🟢 96 🟢 100 🟠 86 Report
/blog/preparing-your-site-for-docusaurus-v3 🟠 65 🟢 92 🟢 100 🟢 100 Report
/blog/tags/release 🟠 64 🟢 96 🟢 100 🟠 86 Report
/blog/tags 🟠 74 🟢 100 🟢 100 🟠 86 Report

@slorber slorber changed the title feat: migrate breadcrumbs structured data to json-ld fix(seo): docs breadcrumb structured data should use JSON-LD and filter unliked categories Feb 7, 2025
@slorber slorber added the pr: bug fix This PR fixes a bug in a past release. label Feb 7, 2025
Copy link
Collaborator

@slorber slorber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@slorber slorber merged commit 45065e8 into facebook:main Feb 7, 2025
38 of 39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: bug fix This PR fixes a bug in a past release.
Projects
None yet
3 participants