Implement ES2024 Map.groupBy
#1454
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
@lavenzg has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
avp
requested changes
Jun 28, 2024
| groupKey = runtime.makeHandle(std::move(*keyRes)); | ||
|
|
||
| // make it a property key | ||
| auto propertyKeyRes = toPropertyKey(runtime, groupKey); |
There was a problem hiding this comment.
Looks like we're supposed to call GroupBy with "COLLECTION" mode, so we shouldn't be converting to PropertyKey here.
| print(JSON.stringify(map.get('underage'))) | ||
| //CHECK-NEXT: [{"name":"Peter","age":15}] | ||
| print(JSON.stringify(map.get('adult'))) | ||
| //CHECK-NEXT: [{"name":"Mike","age":20},{"name":"John","age":22}] |
There was a problem hiding this comment.
We should also have a couple tests for non-string/int keys.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR implements EcmaScript 2024
Map.groupByTest Plan
Added tests.