Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove out dated caveat about using setTimeout from a headless js task #3847

Merged
merged 2 commits into from
Sep 7, 2023

Conversation

jkells
Copy link
Contributor

@jkells jkells commented Sep 6, 2023

Hey Team,

I think this caveat is outdated.

This was fixed in facebook/react-native#33044 and it's now possible to use setTimeout from a HeadlessJsTask.

See:
facebook/react-native#33043
facebook/react-native#33044

@facebook-github-bot
Copy link

Hi @jkells!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

@netlify
Copy link

netlify bot commented Sep 6, 2023

Deploy Preview for react-native ready!

Name Link
🔨 Latest commit 3980414
🔍 Latest deploy log https://app.netlify.com/sites/react-native/deploys/64f98b560be20000087f74c5
😎 Deploy Preview https://deploy-preview-3847--react-native.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Collaborator

@Simek Simek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @jkells, thank you for catching that! 👍 From the context you have provided it looks like we can indeed remove that note.

Can you also backport this change to the versioned docs located in:

Since according to the commit tags, the fix has been shipped with 0.69 release:

@jkells
Copy link
Contributor Author

jkells commented Sep 7, 2023

No probs @Simek that's done.

Copy link
Collaborator

@Simek Simek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the updates, LGTM! 🚀

@Simek Simek merged commit 7211831 into facebook:main Sep 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants