Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Android headless JS timeout #33044

Closed
wants to merge 1 commit into from
Closed

fix: Android headless JS timeout #33044

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions ReactAndroid/src/main/java/com/facebook/react/jstasks/HeadlessJsTaskContext.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,9 +61,15 @@ private HeadlessJsTaskContext(ReactContext reactContext) {
mReactContext = new WeakReference<ReactContext>(reactContext);
}

/** Register a task lifecycle event listener. */
public void addTaskEventListener(HeadlessJsTaskEventListener listener) {
/**
* Register a task lifecycle event listener. Synchronized in order to prevent race conditions
* with finishTask, as the listener will be invoked for already running tasks.
*/
public synchronized void addTaskEventListener(HeadlessJsTaskEventListener listener) {
mHeadlessJsTaskEventListeners.add(listener);
for (Integer activeTaskId: mActiveTasks) {
listener.onHeadlessJsTaskStart(activeTaskId);
}
}

/** Unregister a task lifecycle event listener. */
Expand Down