Make setPointerEvents public on ReactViewGroup.java #45975
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
I maintain the
react-native-svg
library, where our elements extendReactViewGroup
. Currently,ReactViewGroup
only exposes the getter formPointerEvents
publicly, so we cannot set it. To properly handlepointerEvents
, we would have to duplicate all methods related tomPointerEvents
, which results in maintaining a separate state. This duplication can lead to desynchronization between the state in our class and the state in the superclass.PR with a workaround that we can avoid with this change software-mansion/react-native-svg#2395
Changelog:
[ANDROID] [CHANGED] - make
setPointerEvents
publicTest Plan:
This change was tested manually by making the field public, allowing dependent classes to override or reference it.