Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move mediaQuery from npm to modules #261

Merged
merged 1 commit into from
Jan 21, 2025
Merged

Move mediaQuery from npm to modules #261

merged 1 commit into from
Jan 21, 2025

Conversation

necolas
Copy link
Contributor

@necolas necolas commented Jan 21, 2025

Bring the mediaQuery module source code into the repository, and apply the memoization patch. Convert to esm module format.

Copy link

workflow: benchmarks/size

Comparison of minified (terser) and compressed (brotli) size results, measured in bytes. Smaller is better.

Results Base Patch Ratio
react-strict-dom/dist/dom/index.js
· compressed 2,515 2,515 1.00
· minified 8,688 8,688 1.00
react-strict-dom/dist/dom/runtime.js
· compressed 855 855 1.00
· minified 2,435 2,435 1.00
react-strict-dom/dist/native/index.js
· compressed 15,834 15,875 1.00 +
· minified 59,133 59,417 1.00 +

Copy link

github-actions bot commented Jan 21, 2025

workflow: benchmarks/perf (native)

Comparison of performance test results, measured in operations per second. Larger is better.

Results Base Patch Ratio
css.create
· small 1,089,900 1,136,770 1.04 +
· small with units 424,820 436,679 1.03 +
· small with variables 666,782 660,314 0.99 -
· several small 310,133 320,202 1.03 +
· large 210,322 213,968 1.02 +
· large with polyfills 145,903 148,072 1.01 +
· complex 100,615 101,291 1.01 +
· unsupported 221,473 224,485 1.01 +
css.createTheme
· simple theme 227,422 226,435 1.00 -
· polyfill theme 215,681 214,835 1.00 -
css.props
· small 244,041 244,632 1.00 +
· small with units 190,058 191,015 1.01 +
· small with variables 103,906 104,678 1.01 +
· small with variables of units 74,937 74,721 1.00 -
· large 104,576 104,397 1.00 -
· large with polyfills 37,002 37,034 1.00 +
· complex 23,525 23,481 1.00 -
· unsupported 153,002 152,455 1.00 -
· simple merge 163,491 163,183 1.00 -
· wide merge 17,901 17,758 0.99 -
· deep merge 17,449 17,485 1.00 +
· themed merge 31,492 31,636 1.00 +

Bring the mediaQuery module source code into the repository, and apply
the memoization patch. Convert to esm module format.
@necolas necolas merged commit 331148b into main Jan 21, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants