Partial polyfill for CSS 'visibility' #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
compressed-size: runtime library Size change: +0.04 kB
View unchanged
|
nmn
reviewed
Feb 24, 2024
necolas
force-pushed
the
polyfill-visibility
branch
from
7235c18 to
3f75b58
Compare
Implements a partial polyfill for non-inheritable 'visibility'. This does not polyfill the web behavior of being able to selectively override the 'visibility' of elements nested within an element with 'visibility:hidden'. As result, this patch also removes 'visibility' from the inheritable text styles. Originally visibility was added here simply because it is considered an inheritable property on web, even though we didn't do anything with the property on native. In the context of these polyfills, we're only interested in being able to inherit text styles and cannot do anything with inherited visibility, so there is no functional change to the existing polyfill for inheritable text styles. Also note that no attempt is made to implement 'collapse' as per W3C spec, as this behavior does not appear to be supported for flex items in Chrome anyway (which behave the same whether 'collapse' or 'hidden' is used.)
necolas
force-pushed
the
polyfill-visibility
branch
from
3f75b58 to
c631159
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements a partial polyfill for non-inheritable 'visibility'. This does not polyfill the web behavior of being able to selectively override the 'visibility' of elements nested within an element with 'visibility:hidden'.
As result, this patch also removes 'visibility' from the inheritable text styles. Originally visibility was added here simply because it is considered an inheritable property on web, even though we didn't do anything with the property on native. In the context of these polyfills, we're only interested in being able to inherit text styles and cannot do anything with inherited visibility, so there is no functional change to the existing polyfill for inheritable text styles.
Also note that no attempt is made to implement 'collapse' as per W3C spec, as this behavior does not appear to be supported for flex items in Chrome anyway (which behave the same whether 'collapse' or 'hidden' is used.)