Fix spellcheking in beforeInput bug on firefox #24882
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixed spellcheking bug in firefox fixed react spellcheking on beforeinput bug
juank1809
changed the title
|
Comparing: 357a613...860c296 Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: (No significant changes) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This resolves #24358, in which the beforeInputEvent wasn't firing when triggering a spellchecking in firefox. The problem was in the getFallbackBeforeInputChars function: the spellchecking event is interpreted as an 'input' event in firefox, which the function wasn't handling.
How did you test this change?
I tested this change in the fixtures/packaging/babel-standalone/dev.html recreating the exact sandbox that creator of the issue built and the beforeInput fires as expected.