make methods_with_code_changes deterministic

Reviewed By: ssj933 Differential Revision: D51873080 fbshipit-source-id: 9f1a93e89eba67d14fcb148fce1047177636eedd
facebook · Dec 6, 2023 · 702b4c3 · 702b4c3
1 parent 292be93
commit 702b4c3
Showing 1 changed file with 4 additions and 2 deletions.
diff --git a/libredex/Reachability.cpp b/libredex/Reachability.cpp
@@ -1870,8 +1870,10 @@ void ReachableAspects::finish(const ConditionallyMarked& cond_marked,
     add(map);
   }
   for (auto&& [method, mrefs_gatherer] : remaining_mrefs_gatherers) {
-    non_returning_insns.emplace(method,
-                                mrefs_gatherer->get_non_returning_insns());
+    auto set = mrefs_gatherer->get_non_returning_insns();
+    if (!set.empty()) {
+      non_returning_insns.emplace(method, std::move(set));
+    }
   }
   std::atomic<uint64_t> concurrent_instructions_unvisited{0};
   workqueue_run<std::pair<const DexMethod*, const MethodReferencesGatherer*>>(