Skip to content

Commit

Permalink
Properly propagate the result io_status handle upstream (#13238)
Browse files Browse the repository at this point in the history
Summary:
Followup to #13228. This fix is not a critical one in a sense that `else`-branch is only supposed to act as a guard just in case when new work item type is being introduced, scheduled but not handled. However, we're in control of the work item types and currently we only support a single one (which has appropriate handling logic to it).

Pull Request resolved: #13238

Reviewed By: pdillinger

Differential Revision: D67512001

Pulled By: mszeszko-meta

fbshipit-source-id: 71e74b3dac388882dd3757871f500c334667fbd1
  • Loading branch information
mszeszko-meta authored and facebook-github-bot committed Dec 20, 2024
1 parent 19e4aba commit 18cecb9
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion utilities/backup/backup_engine.cc
Original file line number Diff line number Diff line change
Expand Up @@ -1343,11 +1343,11 @@ IOStatus BackupEngineImpl::Initialize() {
work_item.dst_path.c_str(), checksum_function_info.c_str());
}
}
work_item.result.set_value(std::move(result));
} else {
result.io_status = IOStatus::InvalidArgument(
"Unknown work item type: " + std::to_string(work_item.type));
}
work_item.result.set_value(std::move(result));
}
});
}
Expand Down

0 comments on commit 18cecb9

Please sign in to comment.