-
Notifications
You must be signed in to change notification settings - Fork 6.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Experiment: verify secondaries in crash test by recreating expected state as of sequence number #13266
Draft
archang19
wants to merge
15
commits into
facebook:main
Choose a base branch
from
archang19:stress-test-follower
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+414
−148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
archang19
force-pushed
the
stress-test-follower
branch
3 times, most recently
from
January 6, 2025 23:52
e9fdd31
to
bd06353
Compare
archang19
force-pushed
the
stress-test-follower
branch
from
January 7, 2025 17:34
bd06353
to
3316533
Compare
archang19
force-pushed
the
stress-test-follower
branch
from
January 7, 2025 18:16
3316533
to
de7f11c
Compare
archang19
changed the title
[Experimental] See how we can test followers and secondaries
Experiment: verify secondaries in crash test by recreating expected state as of sequence number
Jan 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here I experiment with one approach to verify secondaries in the crash tests. I take the most recent
state
file, replay thetrace
file up to a certain sequence number, and create anExpectedState
representing the target state as of a particular point in time. ThisExpectedState
gets used to run comparisons against the secondary.