Add more options to C api for backups and getting info from them #13270
+119
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jurmous
force-pushed
the
c-api-backup-options
branch
2 times, most recently
from
c56ed9b to
c619d92
Compare
jurmous
force-pushed
the
c-api-backup-options
branch
from
c619d92 to
3cdc8fe
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some API calls were missing for backup options in the C api like rocksdb_backup_engine_delete_backup, rocksdb_backup_engine_get_corrupted_backups, rocksdb_backup_engine_garbage_collect, rocksdb_backup_engine_info_app_metadata. This pull request adds these methods and a new method to make and destroy create backup options through methods like rocksdb_create_backup_options_create, rocksdb_create_backup_options_destroy and rocksdb_create_backup_options_set_flush_before_backup.