Bazel: Fix relative go to definition in external repositories #103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For relative loads from external repositories, the resolve root was calcualated incorrectly. Instead of _removing_ the path of the file within the external repository, it only kept this part. For example if the current file was `$(bazel info output_base)/external/foo/bar/BUILD`, it would compute the resolve root as `bar/BUILD`, whereas it needs to be `$(bazel info output_base)/external/foo`.
facebook-github-bot
added
the
CLA Signed
|
@ndmitchell has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@ndmitchell merged this pull request in c696737. |
facebook-github-bot
pushed a commit
to facebook/buck2
that referenced
this pull request
Jan 19, 2024
Summary: The resolve root was calculated incorrectly for relative load statements in external repositories. Instead of removing the file's path relative to the external repository, it only kept this part. For example if the current file is `$(bazel info output_base)/external/foo/bar/BUILD`, it would compute the resolve root as `bar/BUILD`, whereas it needs to be `$(bazel info output_base)/external/foo`. X-link: facebook/starlark-rust#103 Reviewed By: stepancheg Differential Revision: D52887182 Pulled By: ndmitchell fbshipit-source-id: 3025ae7be81a85976f2e250c104de7163db6a6a5
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The resolve root was calculated incorrectly for relative load statements in external repositories. Instead of removing the file's path relative to the external repository, it only kept this part. For example if the current file is
$(bazel info output_base)/external/foo/bar/BUILD, it would compute the resolve root asbar/BUILD, whereas it needs to be$(bazel info output_base)/external/foo.