Re-enable completions #113
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
@ndmitchell has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
Oops. Thanks for the fix. |
|
@ndmitchell merged this pull request in 581baa8. |
facebook-github-bot
pushed a commit
to facebook/buck2
that referenced
this pull request
Feb 21, 2024
Summary: 4be1b3bbf38dbddfca9aabacbff82a644681ae9d disabled autocomplete by passing no completion provider to the client. However, I think the intention was to just remove the triggers, not disable all autocomplete. This re-enables this functionality. Fixes facebook/starlark-rust#112 X-link: facebook/starlark-rust#113 Reviewed By: stepancheg Differential Revision: D53956003 Pulled By: ndmitchell fbshipit-source-id: 0f060a9fe008897357af75b091f8092010b1c43f
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
4be1b3b disabled autocomplete by passing no completion provider to the client. However, I think the intention was to just remove the triggers, not disable all autocomplete. This re-enables this functionality.
Fixes #112