Update to curve25519-dalek pre-release
#61
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on facebook/opaque-ke#261 I realized that the current version of
x25519-dalekis not compatible with RustCrypto because it pins for examplezeroizeto an old version. Cargo doesn't not allow the same major version of a dependency to exist in the same dependency tree.After some research I pretty much established that the pre-releases are not really experimental but are just semver-incompatible versions of the stable versions with updated dependencies. Basically it fits our bill.
In
opaque-kewe will pull the pre-release versions ofcurve25519-dalekandx25519-dalekand won't have tons of duplicate dependencies this way.