Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[accuracy] modeling changes for calculate_decomp_spend_dist #1175

Merged
merged 3 commits into from
Dec 6, 2024
Merged

[accuracy] modeling changes for calculate_decomp_spend_dist #1175

merged 3 commits into from
Dec 6, 2024

Conversation

alxlyj
Copy link
Contributor

@alxlyj alxlyj commented Dec 5, 2024 •
edited
Loading

Project Robyn

Summary

  • Added absolute value calculation for effect: effect = np.abs(coef * spend)
  • Using absolute values for non-zero effect calculation: non_zero_effect = np.abs(X[col][non_zero_mask] * coef)
  • Effect shares are now calculated using these absolute effects
image

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Dec 5, 2024
@alxlyj alxlyj changed the base branch from main to robynpy_release December 6, 2024 02:37
@alxlyj alxlyj marked this pull request as ready for review December 6, 2024 19:12
dhavalpatel624624
dhavalpatel624624 approved these changes Dec 6, 2024
View reviewed changes
Copy link
Contributor

@dhavalpatel624624 dhavalpatel624624 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@alxlyj alxlyj merged commit 7c020a1 into robynpy_release Dec 6, 2024
2 checks passed
@alxlyj alxlyj deleted the accuracy/allocator_pareto_clustering_visuals branch December 6, 2024 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhavalpatel624624 dhavalpatel624624 dhavalpatel624624 approved these changes

@sumane81 sumane81 Awaiting requested review from sumane81

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alxlyj @dhavalpatel624624 @facebook-github-bot