Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unsubscribe React DevTools events #129

Merged
merged 2 commits into from
Oct 16, 2024

Conversation

EdmondChuiHW
Copy link

@EdmondChuiHW EdmondChuiHW commented Oct 16, 2024

Summary

We should not have dangling listeners.

This could be the cause of some "Attempted to send a message to domain [] while queue is not empty" errors.

Stacked on #117

Test plan

  1. Connect to DevTools
  2. Use DevTools-on-DevTools to set a breakpoint in dispose.
  3. Kill the native app and ensure dispose called (and runtimeModel is non-null`

Upstreaming plan

  • This commit should be sent as a patch to the upstream devtools-frontend repo. I've reviewed the contribution guide.
  • This commit is React Native-specific and cannot be upstreamed.

@EdmondChuiHW EdmondChuiHW requested review from hoxyq, huntie, vzaidman and robhogan and removed request for hoxyq and huntie October 16, 2024 15:04
@EdmondChuiHW EdmondChuiHW marked this pull request as ready for review October 16, 2024 15:04
@hoxyq
Copy link

hoxyq commented Oct 16, 2024

This could be the cause of some "Attempted to send a message to domain [] while queue is not empty" errors.

Oooh, great catch, thanks!

@EdmondChuiHW EdmondChuiHW merged commit d78948c into facebookexperimental:main Oct 16, 2024
3 checks passed
@EdmondChuiHW EdmondChuiHW deleted the unsub-rdt branch October 16, 2024 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants