-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new 'open externally' button #134
Add new 'open externally' button #134
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
c05c30b
to
a5f9d72
Compare
Updated design based on @huntie's feedback 🙌 |
a5f9d72
to
66cc6ae
Compare
var enableReactNativeOpenSourceFilesInExternalEditor: boolean|undefined; | ||
var reactNativeOpenSourceFilesInExternalEditorButtonBackgroundImage: string|undefined; | ||
var reactNativeOpenSourceFilesInExternalEditorButtonPadding: string|undefined; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Paired with my other feedback on D65551943.
var enableReactNativeOpenSourceFilesInExternalEditor: boolean|undefined; | |
var reactNativeOpenSourceFilesInExternalEditorButtonBackgroundImage: string|undefined; | |
var reactNativeOpenSourceFilesInExternalEditorButtonPadding: string|undefined; | |
var enableReactNativeOpenInExternalEditor: boolean|undefined; // Also, deletable if we align /open-stack-frame | |
var reactNativeOpenInEditorButtonImage: string|undefined; |
adorner.style.setProperty('background-image', maybeBackgroundImage); | ||
adorner.style.setProperty( | ||
'padding', | ||
globalThis.reactNativeOpenSourceFilesInExternalEditorButtonPadding ?? '4px', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please kill, see D65551943 comment.
66cc6ae
to
023a674
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
Summary
Add a new button to open the source file at the current line in an external editor , e.g. VS Code
This is current not supported in the community version of Metro or Fusebox.
Test plan
Requires D65551943
Upstreaming plan
devtools-frontend
repo. I've reviewed the contribution guide.