Replace Fusebox setClientMetadata handshake with ReactNativeApplicationModel #139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
huntie
added a commit
to huntie/react-native
that referenced
this pull request
Nov 28, 2024
Summary: Follows facebook#47962 and depends on facebookexperimental/rn-chrome-devtools-frontend#139. Updates the modern debugger server to no longer respond to `FuseboxClient` messages — namely `FuseboxClient.setClientMetadata`. This method was previously used to identify the React Native DevTools frontend, replaced/inferred by `ReactNativeApplication.enable` instead. Changelog: [General][Breaking] - The `FuseboxClient.setClientMetadata` CDP method is removed. Instead, use `ReactNativeApplication.enable`. Differential Revision: D66575324
This was referenced Nov 28, 2024
hoxyq
requested changes
Dec 2, 2024
Comment on lines
+35
to
+46
| void this.#agent.invoke_enable() | ||
| .then(result => { | ||
| const maybeError = result.getError(); | ||
| const success = !maybeError; | ||
| Host.rnPerfMetrics.fuseboxSetClientMetadataFinished(success, maybeError); | ||
| }) | ||
| .catch(reason => { | ||
| const success = false; | ||
| Host.rnPerfMetrics.fuseboxSetClientMetadataFinished(success, reason); | ||
| }); |
There was a problem hiding this comment.
I believe you are missing Host.rnPerfMetrics.fuseboxSetClientMetadataStarted(); somewhere here
huntie
force-pushed
the
drop-fusebox-client-domain
branch
from
eab7902 to
e7818f6
Compare
hoxyq
approved these changes
Dec 2, 2024
facebook-github-bot
pushed a commit
to facebook/react-native
that referenced
this pull request
Dec 2, 2024
Summary: Pull Request resolved: #48004 Follows #47962 and depends on facebookexperimental/rn-chrome-devtools-frontend#139. Updates the modern debugger server to no longer respond to `FuseboxClient` messages — namely `FuseboxClient.setClientMetadata`. This method is replaced by `ReactNativeApplication.enable` for identifying the React Native DevTools frontend. Changelog: [General][Breaking] - The `FuseboxClient.setClientMetadata` CDP method is removed. Instead, use `ReactNativeApplication.enable`. Reviewed By: rubennorte Differential Revision: D66575324 fbshipit-source-id: f2b4cbacd857931832d89305510f5aaf51df483a
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Depends on facebook/react-native#47962.
In an aim to simplify the
rn_fusebox.tsentry point, drops our use ofFuseboxClient.setClientMetadataas a RNDT-client-identifying handshake, in favourReactNativeApplication.enable.FuseboxClientMetadataModelwith existingReactNativeApplicationModelrn_fusebox.ts(IMO, correctness fix that now includes this model only for this entrypoint).rnPerfMetricscalls over (unchanged).FuseboxClientdomain.Test plan
[Meta internal] See D66501027.
Upstreaming plan
devtools-frontendrepo. I've reviewed the contribution guide.