Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify appearance of internal feedback button #142

Merged
merged 1 commit into from
Dec 2, 2024

Conversation

huntie
Copy link

@huntie huntie commented Nov 28, 2024

Summary

Tweaks our custom-styled internal feedback toolbar item. Reduces visual prominence so that other items / future background colouring will fit better.

Test plan

image
  • This change maintains backwards compatibility with previous Local Storage data (if modifying settings, experiments, or other persisted client state).

Upstreaming plan

  • This commit should be sent as a patch to the upstream devtools-frontend repo. I've reviewed the contribution guide.
  • This commit is React Native-specific and cannot be upstreamed.

@huntie huntie merged commit 0d6f1e4 into facebookexperimental:main Dec 2, 2024
3 checks passed
@huntie huntie deleted the feedback-btn-appearance branch December 2, 2024 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants