forked from ChromeDevTools/devtools-frontend
-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: add actual stub view for React DevTools panel #17
Merged
hoxyq
merged 1 commit into
facebookexperimental:main
from
hoxyq:react-devtools/add-panel-stub
Apr 9, 2024
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,32 @@ | ||
| // Copyright (c) Meta Platforms, Inc. and affiliates. | ||
| // Copyright 2024 The Chromium Authors. All rights reserved. | ||
| // Use of this source code is governed by a BSD-style license that can be | ||
| // found in the LICENSE file. | ||
|
|
||
| import * as UI from '../../ui/legacy/legacy.js'; | ||
|
|
||
| let instance: ReactDevToolsViewImpl; | ||
|
|
||
| export class ReactDevToolsViewImpl extends UI.Widget.VBox { | ||
| static instance(): ReactDevToolsViewImpl { | ||
| if (!instance) { | ||
| instance = new ReactDevToolsViewImpl(); | ||
| } | ||
|
|
||
| return instance; | ||
| } | ||
|
|
||
| private constructor() { | ||
| super(true, true); | ||
| } | ||
|
|
||
| override wasShown(): void { | ||
| super.wasShown(); | ||
|
|
||
| this.render(); | ||
| } | ||
|
|
||
| render(): void { | ||
| return; | ||
| } | ||
| } |
2 changes: 1 addition & 1 deletion
2
..._placeholder/reactDevToolsPlaceholder.css → ...act_devtools/reactDevToolsPlaceholder.css
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,54 @@ | ||
| // Copyright (c) Meta Platforms, Inc. and affiliates. | ||
| // Copyright 2024 The Chromium Authors. All rights reserved. | ||
| // Use of this source code is governed by a BSD-style license that can be | ||
| // found in the LICENSE file. | ||
|
|
||
| import * as i18n from '../../core/i18n/i18n.js'; | ||
| import * as Root from '../../core/root/root.js'; | ||
| import * as UI from '../../ui/legacy/legacy.js'; | ||
|
|
||
| import type * as ReactDevToolsPanelModule from './react_devtools.js'; | ||
|
|
||
| const UIStrings = { | ||
| /** | ||
| * @description React DevTools panel title | ||
| */ | ||
| title: '⚛️ React DevTools', | ||
|
|
||
| /** | ||
| * @description Command for showing the React DevTools panel | ||
| */ | ||
| command: 'Show React DevTools panel', | ||
| }; | ||
| const str_ = i18n.i18n.registerUIStrings('panels/react_devtools/react_devtools-meta.ts', UIStrings); | ||
| const i18nLazyString = i18n.i18n.getLazilyComputedLocalizedString.bind(undefined, str_); | ||
|
|
||
| let loadedModule: (typeof ReactDevToolsPanelModule|undefined); | ||
|
|
||
| async function loadModule(): Promise<typeof ReactDevToolsPanelModule> { | ||
| if (!loadedModule) { | ||
| loadedModule = await import('./react_devtools.js'); | ||
| } | ||
| return loadedModule; | ||
| } | ||
|
|
||
| UI.ViewManager.registerViewExtension({ | ||
| location: UI.ViewManager.ViewLocationValues.PANEL, | ||
| id: 'react-devtools', | ||
| title: i18nLazyString(UIStrings.title), | ||
| commandPrompt: i18nLazyString(UIStrings.command), | ||
| persistence: UI.ViewManager.ViewPersistence.PERMANENT, | ||
| async loadView() { | ||
| const Module = await loadModule(); | ||
|
|
||
| if (Root.Runtime.Runtime.isDescriptorEnabled({ | ||
| experiment: Root.Runtime.ExperimentName.ENABLE_REACT_DEVTOOLS_PANEL, | ||
| condition: null, | ||
| })) { | ||
| return Module.ReactDevToolsView.ReactDevToolsViewImpl.instance(); | ||
| } | ||
|
|
||
| return Module.ReactDevToolsPlaceholder.ReactDevToolsPlaceholderImpl.instance(); | ||
| }, | ||
| }); | ||
|
|
||
9 changes: 3 additions & 6 deletions
9
...placeholder/react_devtools_placeholder.ts → ...d/panels/react_devtools/react_devtools.ts
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,12 +1,9 @@ | ||
| // Copyright (c) Meta Platforms, Inc. and affiliates. | ||
| // Copyright 2019 The Chromium Authors. All rights reserved. | ||
| // Copyright 2024 The Chromium Authors. All rights reserved. | ||
| // Use of this source code is governed by a BSD-style license that can be | ||
| // found in the LICENSE file. | ||
|
|
||
| import './ReactDevToolsPlaceholder.js'; | ||
|
|
||
| import * as ReactDevToolsView from './ReactDevToolsView.js'; | ||
| import * as ReactDevToolsPlaceholder from './ReactDevToolsPlaceholder.js'; | ||
|
|
||
| export { | ||
| ReactDevToolsPlaceholder, | ||
| }; | ||
| export {ReactDevToolsView, ReactDevToolsPlaceholder}; |
46 changes: 0 additions & 46 deletions
46
front_end/panels/react_devtools_placeholder/react_devtools_placeholder-meta.ts
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cc @huntie for future references on using experiments declaratively
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@hoxyq how about creating a wiki page (GH or internal) with these learnings?