Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add global typings to path #18

Merged
merged 1 commit into from
Mar 12, 2024

Conversation

EdmondChuiHW
Copy link

Summary

As discussed in #16 (comment)

Itooks like linter doesn't check the .d.ts. The upstream file here doesn't have license and the linter doesn't complain:

Adding ours to the list for clarity of intention.

Test plan

npm run check-lint

(Ignore the unrelated files)

Upstreaming plan

  • This commit should be sent as a patch to the upstream devtools-frontend repo. I've reviewed the contribution guide.
  • This commit is React Native-specific and cannot be upstreamed.

@EdmondChuiHW EdmondChuiHW marked this pull request as ready for review March 12, 2024 15:41
@EdmondChuiHW EdmondChuiHW requested a review from hoxyq March 12, 2024 15:42
@EdmondChuiHW EdmondChuiHW merged commit 2394a3c into facebookexperimental:main Mar 12, 2024
3 checks passed
@EdmondChuiHW EdmondChuiHW deleted the meta-license branch March 12, 2024 16:43
@motiz88
Copy link

motiz88 commented Mar 12, 2024

@EdmondChuiHW, note that you ended up merging a commit with an unclear title to main.
image

@EdmondChuiHW
Copy link
Author

@motiz88 sorry. Thought the squash-and-merge option would take the PR title. Will make sure to double-check that in the future

EdmondChuiHW pushed a commit that referenced this pull request Mar 14, 2024
This reverts commit 2394a3c.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants