Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
As discussed in #16 (comment)
Itooks like linter doesn't check the
.d.ts
. The upstream file here doesn't have license and the linter doesn't complain:rn-chrome-devtools-frontend/front_end/global_typings/request_idle_callback.d.ts
Line 1 in 9370b35
Adding ours to the list for clarity of intention.
Test plan
npm run check-lint
(Ignore the unrelated files)
Upstreaming plan
devtools-frontend
repo. I've reviewed the contribution guide.