Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix[ci/build]: move RDT artifacts to debug_sources #45

Merged
merged 1 commit into from
Apr 15, 2024

Conversation

hoxyq
Copy link

@hoxyq hoxyq commented Apr 15, 2024

Summary

Move RDT bindings model and RDT artifacts to debug_sources.

The general idea is that only entrypoints, and static resources should be listed in release_sources. Basically everything, what is copied to release build or if used as a source for an entrypoint / module.

Manually observing the release build artifacts confirms that all these files are actually inlined into their corresponding entrypoints:

  • RDT artifacts into third_party/react_devtools/react_devtools.js
  • ReactDevToolsBindingsModel into models/react_native/react_native.js

Test plan

  • npm run build produces no errors
  • npm run build-release produces no errors

Upstreaming plan

  • This commit should be sent as a patch to the upstream devtools-frontend repo. I've reviewed the contribution guide.
  • This commit is React Native-specific and cannot be upstreamed.

@hoxyq hoxyq merged commit f310871 into facebookexperimental:main Apr 15, 2024
3 checks passed
@hoxyq hoxyq deleted the react-devtools/fix-ci branch April 15, 2024 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants