fix[ci/build]: move RDT artifacts to debug_sources #45
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Move RDT bindings model and RDT artifacts to debug_sources.
The general idea is that only entrypoints, and static resources should be listed in release_sources. Basically everything, what is copied to release build or if used as a source for an entrypoint / module.
Manually observing the release build artifacts confirms that all these files are actually inlined into their corresponding entrypoints:
third_party/react_devtools/react_devtools.js
models/react_native/react_native.js
Test plan
npm run build
produces no errorsnpm run build-release
produces no errorsUpstreaming plan
devtools-frontend
repo. I've reviewed the contribution guide.