Clippy lints #8233
Closed
Clippy lints #8233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Differential Revision: D59021487
Differential Revision: D59021488
Differential Revision: D59021491
Summary: Format automatically gives you ToString. If we directly implement ToString the to_string_trait_impl Clippy lint will be fired: https://rust-lang.github.io/rust-clippy/master/index.html#/to_string_trait_impl Differential Revision: D59021486
Differential Revision: D59021489
Differential Revision: D59021482
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D59065418 |
|
This pull request was exported from Phabricator. Differential Revision: D59065418 |
brianc118
force-pushed
the
export-D59065418
branch
2 times, most recently
from
b2cbe18 to
650b995
Compare
|
This pull request was exported from Phabricator. Differential Revision: D59065418 |
Differential Revision: D59021483
Differential Revision: D59021480
Differential Revision: D59021484
Differential Revision: D59021490
Differential Revision: D59021485
Differential Revision: D59021481
Differential Revision: D59065420
Differential Revision: D59065419
Differential Revision: D59065418
|
This pull request was exported from Phabricator. Differential Revision: D59065418 |
brianc118
force-pushed
the
export-D59065418
branch
from
650b995 to
cb4bc99
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Run clippy on all the crates.
Differential Revision: D59065418