Fix multiprocessing dataloader checkpointing and use it in the train script #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
sriniiyer
reviewed
Feb 11, 2025
| @@ -236,7 +236,7 @@ def create_iter( | |||
|
|
|||
| def _set_row_num(self, target_row_num: int): | |||
| logger.info( | |||
| f"Setting arrow position to {target_row_num} for {self.dataset_files}" | |||
| f"Setting arrow position to {target_row_num} for {str(self.dataset_files)[:200]}" | |||
There was a problem hiding this comment.
Perhaps mention in the print that its the top 200 in this case
There was a problem hiding this comment.
The list of files can be quite large, this effectively just truncates the log length.
There was a problem hiding this comment.
Just add a .... or something to indicate that we arent printing the entire list, so that we dont look at the log and wrongly infer that some datasets are being skipped
sriniiyer
reviewed
Feb 11, 2025
| @@ -286,5 +286,5 @@ def _set_row_num(self, target_row_num: int): | |||
| curr_remaining -= len(batch) | |||
| self.row_num = target_row_num | |||
| logger.info( | |||
| f"Finished setting arrow position to {target_row_num} for {self.dataset_files}" | |||
| f"Finished setting arrow position to {target_row_num} for {str(self.dataset_files)[:200]}" | |||
Merged
EntilZha
force-pushed
the
pr50
branch
2 times, most recently
from
bd3cf61 to
3e3193c
Compare
…script Summary: Test Plan:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Test Plan: