Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[doc] pytorch lightning example #6

Open
wants to merge 13 commits into
base: main
Choose a base branch
from
Open

[doc] pytorch lightning example #6

wants to merge 13 commits into from

Conversation

kingjr
Copy link
Contributor

@kingjr kingjr commented Dec 11, 2024

No description provided.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Meta Open Source bot. label Dec 11, 2024
kingjr
kingjr commented Dec 16, 2024
View reviewed changes
docs/infra/example_lightning.py
pretrained: bool = True
learning_rate: float = 0.001

model_config = pydantic.ConfigDict(extra="forbid")
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be automatically dealt by infra IMO

jrapin
jrapin reviewed Dec 24, 2024
View reviewed changes
docs/infra/example_lightning.py

# Return model if not saved
if self.checkpoint_path is None:
return model
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is solving the caching issue of models with a really bad practice (changing output type depending on the inputs) :s I don't know how to solve this one though

@jrapin jrapin changed the title [WIP] doc: pytorch lightning example [doc] pytorch lightning example Dec 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jrapin jrapin jrapin left review comments

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Meta Open Source bot.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kingjr @jrapin @facebook-github-bot