Feat: play on paste . #49
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
Celebio
reviewed
Jul 18, 2023
| @@ -121,14 +121,14 @@ function useFileNavigate() { | |||
| } | |||
|
|
|||
| const Files = (): JSX.Element => { | |||
| const [displayHelper, setDisplayHelper] = useState(false); | |||
| const [displayHelper, setDisplayHelper] = useState(false); | |||
There was a problem hiding this comment.
Doesn't the linter remove this trailing spaces? Did you install and run pre-commit ?
| @@ -183,6 +194,7 @@ const Files = (): JSX.Element => { | |||
| onChange={setFilenameEventHandler} | |||
| value={newFilename} | |||
| onKeyDown={fileInputHandleChange} | |||
| onPaste={fileInputHandlePaste} | |||
I'll install and rum pre-commit and write up the test as well |
|
Thank you @greatsage-raphael. There are too many files affected by the linter, and I am wondering if this is due to some version mismatch. In any case, can you run the linter only on the files that you modified? We can decide later if it makes sense to run it on all files, but it should be a separate commit anyway. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why ?
Usually when we paste something in the query textbox, the next action is to click on "fetch" or press enter. This feature detects a paste and automatically execute the query. Fixes #36
How ?
It uses the onPaste event listener of the input field to detect a paste operation and automatically executes the query by calling a function
Test plan
Paste filename into the input field and observe that the pasted filename automatically executes without manual intervention.