will compile?

facontidavide · Jan 19, 2025 · 7406875 · 7406875
1 parent 86df02e
commit 7406875
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 6 deletions.
diff --git a/3rdparty/CMakeLists.txt b/3rdparty/CMakeLists.txt
@@ -1,9 +1,12 @@
 
 ##### fastCDR ######
-
-find_package(fastcdr QUIET)
-if (NOT fastcdr_FOUND)
-    CPMAddPackage("gh:eProsima/[email protected]")
+if(NOT TARGET fastcdr)
+    CPMAddPackage(
+        NAME fastcdr_imported
+        GITHUB_REPOSITORY eProsima/Fast-CDR
+        GIT_TAG v2.2.6
+        OPTIONS "BUILD_SHARED_LIBS OFF"
+    )
 endif()
 
 ##### backward_cpp ######

diff --git a/plotjuggler_plugins/ParserROS/rosx_introspection/CMakeLists.txt b/plotjuggler_plugins/ParserROS/rosx_introspection/CMakeLists.txt
@@ -22,8 +22,7 @@ add_library(rosx_introspection STATIC
     src/deserializer.cpp
     )
 
-target_link_libraries(rosx_introspection
-    fastcdr )
+target_link_libraries(rosx_introspection PRIVATE fastcdr )
 
 target_include_directories(rosx_introspection PUBLIC
     $<BUILD_INTERFACE:${CMAKE_CURRENT_SOURCE_DIR}/include>