Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Random BigInt between two long long numbers #27

Closed
wants to merge 2 commits into from
Closed

Random BigInt between two long long numbers #27

wants to merge 2 commits into from

Conversation

wilky-way
Copy link

No description provided.

@faheel
Copy link
Owner

faheel commented May 3, 2018

@awilki13 Thanks for the PR, but having a function to generate a BigInt between two long long ints isn't really useful here. What would be useful is a function that generates a random BigInt between two given BigInts (arbitrary-sized) as mentioned in #19.

To be clear, it should two arguments (low and high) whose type can be any combination of a BigInt, a string or long long int (6 overloaded functions in total), which should return a random BigInt that is between low and high.

I'm closing this PR for now, but in case you decide to implement it, feel free to reopen it and add a comment, and I'll review it. Thanks again for contributing.

@faheel faheel closed this May 3, 2018
@faheel faheel added invalid This doesn't seem right functions: random Random functions labels May 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
functions: random Random functions invalid This doesn't seem right
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants