use redis-cli for the initContainer check #740
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
poiana
added
kind/bug
Issif
force-pushed
the
fix/redis-probe
branch
2 times, most recently
from
f9fcd8e to
2b8ff3f
Compare
alacuku
reviewed
Sep 20, 2024
…is server settings + allow to use a password for the external redis Signed-off-by: Thomas Labarussias <[email protected]>
Issif
force-pushed
the
fix/redis-probe
branch
from
2b8ff3f to
873d9a8
Compare
Signed-off-by: Thomas Labarussias <[email protected]>
This was referenced Sep 20, 2024
Signed-off-by: Thomas Labarussias <[email protected]>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alacuku, Issif The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
LGTM label has been added. Git tree hash: 094fce4986f862208ecc3244985c9a07520a68fe
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
/kind feature
Any specific area of the project related to this PR?
/area falcosidekick-chart
What this PR does / why we need it:
redis-cliby the initContainer of Falcosidekick-UI to wait til the redis is up and runningWhich issue(s) this PR fixes:
#732
falcosecurity/falcosidekick-ui#140
Fixes #
Special notes for your reviewer:
Checklist