Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(falcosidekick): customConfig template fix for webui redis #751

Merged
merged 4 commits into from
Oct 2, 2024
Merged

fix(falcosidekick): customConfig template fix for webui redis #751

merged 4 commits into from
Oct 2, 2024

Conversation

krkjack
Copy link
Contributor

@krkjack krkjack commented Oct 2, 2024

What type of PR is this?

/kind bug

/kind chart-release

Any specific area of the project related to this PR?

/area falcosidekick-chart

What this PR does / why we need it:

Currently defining falcosidekick.webui.redis.customConfigin values.yaml results in templating error:

Error: YAML parse error on falco/charts/falco/charts/falcosidekick/templates/configmap-ui.yaml: error converting YAML to JSON: yaml: line 17: 
did not find expected key

Using --debug switch shows us that one line is unnecessary suppressed (the key data is joined with redis-stack.config):

data:redis-stack.config: |-
    maxmemory-policy allkeys-lfu
    maxmemory 4096mb

Tested with values.yaml:

falcosidekick:
  webui:
    redis:
      customConfig: 
        - maxmemory-policy allkeys-lfu
        - maxmemory 4096mb

Which issue(s) this PR fixes:

Special notes for your reviewer:

Checklist

  • Chart Version bumped
  • Variables are documented in the README.md
  • CHANGELOG.md updated

@poiana poiana added kind/bug Something isn't working dco-signoff: yes kind/chart-release Add this label when the chart version has been bumped area/falcosidekick-chart labels Oct 2, 2024
@poiana
Copy link
Contributor

poiana commented Oct 2, 2024

Welcome @krkjack! It looks like this is your first PR to falcosecurity/charts 🎉

@poiana poiana requested review from alacuku and bencer October 2, 2024 07:13
@poiana poiana added the size/XS label Oct 2, 2024
@poiana poiana added the lgtm label Oct 2, 2024
@poiana
Copy link
Contributor

poiana commented Oct 2, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Issif, krkjack

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana added the approved label Oct 2, 2024
@poiana
Copy link
Contributor

poiana commented Oct 2, 2024

LGTM label has been added.

Git tree hash: ad4d3cd51b7c770b789f53ed9d3889961fc074d1

@poiana poiana merged commit f3c3fd8 into falcosecurity:master Oct 2, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/falcosidekick-chart dco-signoff: yes kind/bug Something isn't working kind/chart-release Add this label when the chart version has been bumped lgtm size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants