Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add a grafana dashboard for the falco talon metrics #803

Merged
merged 1 commit into from
Dec 18, 2024

Conversation

Issif
Copy link
Member

@Issif Issif commented Dec 18, 2024

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

/kind feature

If this PR will release a new chart version please make sure to also uncomment the following line:

/kind chart-release

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area falco-chart

/area falco-exporter-chart

/area falcosidekick-chart

/area falco-talon

/area event-generator-chart

/area k8s-metacollector

What this PR does / why we need it:

Add a Grafana dashboard for the Prom metrics for Talon

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Checklist

  • Chart Version bumped
  • Variables are documented in the README.md
  • CHANGELOG.md updated

@poiana poiana added the kind/feature New feature or request label Dec 18, 2024
@poiana
Copy link
Contributor

poiana commented Dec 18, 2024

@Issif: The label(s) area/falco-talon cannot be applied, because the repository doesn't have them.

In response to this:

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

/kind feature

If this PR will release a new chart version please make sure to also uncomment the following line:

/kind chart-release

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area falco-chart

/area falco-exporter-chart

/area falcosidekick-chart

/area falco-talon

/area event-generator-chart

/area k8s-metacollector

What this PR does / why we need it:

Add a Grafana dashboard for the Prom metrics for Talon

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Checklist

  • Chart Version bumped
  • Variables are documented in the README.md
  • CHANGELOG.md updated

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@poiana poiana requested review from bencer and leogr December 18, 2024 08:00
@Issif Issif force-pushed the falco-talon/grafana-dashboard branch 2 times, most recently from cb8c527 to 3348d8d Compare December 18, 2024 08:10
@Issif Issif force-pushed the falco-talon/grafana-dashboard branch from 3348d8d to efc85c1 Compare December 18, 2024 08:11
Copy link
Member

@alacuku alacuku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@poiana
Copy link
Contributor

poiana commented Dec 18, 2024

LGTM label has been added.

Git tree hash: 4c394ec5ae8903cf185ea0b6c2b03f156f1a110a

@poiana
Copy link
Contributor

poiana commented Dec 18, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alacuku, Issif

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana merged commit 7dfa1e0 into master Dec 18, 2024
6 checks passed
@poiana poiana deleted the falco-talon/grafana-dashboard branch December 18, 2024 08:23
@leogr
Copy link
Member

leogr commented Dec 19, 2024

@Issif: The label(s) area/falco-talon cannot be applied, because the repository doesn't have them.

FYI added area/falco-talon-chart fixed the PR template as well 👉 #804

cc @Issif @alacuku

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants