-
Notifications
You must be signed in to change notification settings - Fork 298
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ports definition for webserver #813
Conversation
Welcome @sylvesterdamgaard! It looks like this is your first PR to falcosecurity/charts 🎉 |
ffe2628
to
9f1492f
Compare
Hi, This is a good point. FYI, a service is created and this the recommended endpoint to scrape. The CI is failing for 2 reasons, you're not responsible of the failure of the For the step |
For some links, we need to add a redirect in the upstream website; for others, we just have to update them here. |
Fixed by #814 @sylvesterdamgaard, May I ask you to rebase this PR, please? In particular, pay attention to use the correct rebasing procedure (to avoid merge commits): https://github.com/falcosecurity/.github/blob/main/CONTRIBUTING.md#resolving-conflicts-by-rebasing If you are unsure or need any help, let me know. Thanks in advance 🙏 |
Update changelog for v4.17.2 Signed-off-by: Sylvester Damgaard <[email protected]>
c8c6652
to
9dd2632
Compare
Signed-off-by: Sylvester Damgaard <[email protected]>
@Issif Good catch. Updated and pushed. |
Now you have update the Chart.yaml, it requires the charts/charts/falco/README.gotmpl Line 592 in afe3b77
|
Signed-off-by: Sylvester Damgaard <[email protected]>
@Issif Sorry about that. I will get the flow eventually! :) |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Issif, sylvesterdamgaard The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
LGTM label has been added. Git tree hash: c06ab926e2b96ee75b9855c27ec781620b2c170c
|
What type of PR is this?
/kind bug
/area falco-chart
What this PR does / why we need it:
This PR adds a ports: section to the Falco container when the webserver/metrics settings are enabled. Without this change, the port isn’t properly exposed, preventing tools like Prometheus or Grafana from scraping metrics. By exposing the webserver port in the Pod spec, other services can now access it as intended.
Which issue(s) this PR fixes:
Fixes #812
Special notes for your reviewer:
No special notes. I’ve already updated the corresponding labels on GitHub.
Checklist
Variables are documented in the README.md