Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ports definition for webserver #813

Merged
merged 3 commits into from
Jan 20, 2025

Conversation

sylvesterdamgaard
Copy link
Contributor

@sylvesterdamgaard sylvesterdamgaard commented Jan 17, 2025

What type of PR is this?

/kind bug

/area falco-chart

What this PR does / why we need it:

This PR adds a ports: section to the Falco container when the webserver/metrics settings are enabled. Without this change, the port isn’t properly exposed, preventing tools like Prometheus or Grafana from scraping metrics. By exposing the webserver port in the Pod spec, other services can now access it as intended.

Which issue(s) this PR fixes:

Fixes #812

Special notes for your reviewer:

No special notes. I’ve already updated the corresponding labels on GitHub.

Checklist

  • Chart Version bumped
  • Variables are documented in the README.md
  • CHANGELOG.md updated

@poiana
Copy link
Contributor

poiana commented Jan 17, 2025

Welcome @sylvesterdamgaard! It looks like this is your first PR to falcosecurity/charts 🎉

@Issif
Copy link
Member

Issif commented Jan 17, 2025

Hi,

This is a good point.

FYI, a service is created and this the recommended endpoint to scrape.

The CI is failing for 2 reasons, you're not responsible of the failure of the Links / linkChecker, we did changes of the docs and some links have been migrated, we'll take care of that, you'll might have to rebase. I'll tell you when it's fixed.

For the step Check Helm Docs / readme, can you run make docs-falco to update the README to reflect your changes, thanks.

@leogr
Copy link
Member

leogr commented Jan 17, 2025

Hi,

This is a good point.

FYI, a service is created and this the recommended endpoint to scrape.

The CI is failing for 2 reasons, you're not responsible of the failure of the Links / linkChecker, we did changes of the docs and some links have been migrated, we'll take care of that, you'll might have to rebase. I'll tell you when it's fixed.

For the step Check Helm Docs / readme, can you run make docs-falco to update the README to reflect your changes, thanks.

For some links, we need to add a redirect in the upstream website; for others, we just have to update them here.
I'm on it. I will keep you posted.

@leogr
Copy link
Member

leogr commented Jan 17, 2025

Fixed by #814

@sylvesterdamgaard, May I ask you to rebase this PR, please?

In particular, pay attention to use the correct rebasing procedure (to avoid merge commits): https://github.com/falcosecurity/.github/blob/main/CONTRIBUTING.md#resolving-conflicts-by-rebasing

If you are unsure or need any help, let me know.

Thanks in advance 🙏

Update changelog for v4.17.2

Signed-off-by: Sylvester Damgaard <[email protected]>
@sylvesterdamgaard
Copy link
Contributor Author

@leogr I believe the PR should be up to code now.
Rebased to remove the commit clutter and updated Changelog for a v4.17.2 release.

@Issif There was no changes to the readme since nothing changed in terms of settings.

@Issif
Copy link
Member

Issif commented Jan 20, 2025

you have to update the version in the Chart.yaml

image

Signed-off-by: Sylvester Damgaard <[email protected]>
@sylvesterdamgaard
Copy link
Contributor Author

you have to update the version in the Chart.yaml

image

@Issif Good catch. Updated and pushed.

@Issif
Copy link
Member

Issif commented Jan 20, 2025

Now you have update the Chart.yaml, it requires the make docs-falco to keep updated the README, see the template:

The following table lists the main configurable parameters of the {{ template "chart.name" . }} chart v{{ template "chart.version" . }} and their default values. See [values.yaml](./values.yaml) for full list.

Signed-off-by: Sylvester Damgaard <[email protected]>
@poiana poiana added size/S and removed size/XS labels Jan 20, 2025
@sylvesterdamgaard
Copy link
Contributor Author

@Issif Sorry about that. I will get the flow eventually! :)

@poiana
Copy link
Contributor

poiana commented Jan 20, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Issif, sylvesterdamgaard

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana added the lgtm label Jan 20, 2025
@poiana
Copy link
Contributor

poiana commented Jan 20, 2025

LGTM label has been added.

Git tree hash: c06ab926e2b96ee75b9855c27ec781620b2c170c

@poiana poiana merged commit b5118f9 into falcosecurity:master Jan 20, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Missing Ports definition in podTemplate
4 participants