Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: bump libs and driver, support field transformers #3186

Merged
merged 7 commits into from
May 8, 2024

Conversation

jasondellaluce
Copy link
Contributor

@jasondellaluce jasondellaluce commented May 6, 2024

What type of PR is this?

/kind feature

Any specific area of the project related to this PR?

/area engine

/area tests

What this PR does / why we need it:

As part of falcosecurity/libs#1789, thus bumps the libs version and adapts Falco for supporting field transformers. This involves updating the visitors with the new AST definitions, collecting warnings emitted by filter compilers, supporting transformers in exceptions, and adding supporting tests.

Which issue(s) this PR fixes:

Special notes for your reviewer:

/milestone 0.38.0

Does this PR introduce a user-facing change?:

refactor: bump libs and driver, support field modifiers 

@poiana
Copy link
Contributor

poiana commented May 6, 2024

@jasondellaluce: The provided milestone is not valid for this repository. Milestones in this repository: [0.38.0, 0.39.0, 1.0.0, TBD]

Use /milestone clear to clear the milestone.

In response to this:

What type of PR is this?

/kind feature

Any specific area of the project related to this PR?

/area engine

/area tests

What this PR does / why we need it:

As part of falcosecurity/libs#1789, thus bumps the libs version and adapts Falco for supporting field transformers. This involves updating the visitors with the new AST definitions, collecting warnings emitted by filter compilers, supporting transformers in exceptions, and adding supporting tests.

Which issue(s) this PR fixes:

Special notes for your reviewer:

/milestone 0.17.0

Does this PR introduce a user-facing change?:

refactor: bump libs and driver, support field modifiers 

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link

github-actions bot commented May 6, 2024

This PR may bring feature or behavior changes in the Falco engine and may require the engine version to be bumped.

Please double check userspace/engine/falco_engine_version.h file. See versioning for FALCO_ENGINE_VERSION.

/hold

@jasondellaluce
Copy link
Contributor Author

/milestone 0.38.0

incertum
incertum previously approved these changes May 7, 2024
Copy link
Contributor

@incertum incertum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@poiana
Copy link
Contributor

poiana commented May 7, 2024

LGTM label has been added.

Git tree hash: 43aa306d5e3f4f3f2356a09b23b1a0086add094c

leogr
leogr previously approved these changes May 8, 2024
@jasondellaluce jasondellaluce force-pushed the refactor/support-field-modifiers branch from 1dee81f to e87b967 Compare May 8, 2024 15:56
@poiana poiana removed the lgtm label May 8, 2024
@poiana poiana requested review from incertum and leogr May 8, 2024 15:57
@poiana poiana added size/XXL and removed size/XL labels May 8, 2024
@poiana poiana added the lgtm label May 8, 2024
@poiana
Copy link
Contributor

poiana commented May 8, 2024

LGTM label has been added.

Git tree hash: a505fe59e4d05f24dc1066083c6c7c68bcf573ea

Copy link
Member

@Andreagit97 Andreagit97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@poiana
Copy link
Contributor

poiana commented May 8, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Andreagit97, incertum, jasondellaluce, leogr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [Andreagit97,incertum,jasondellaluce,leogr]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@incertum
Copy link
Contributor

incertum commented May 8, 2024

/unhold

@poiana poiana merged commit d17f2af into master May 8, 2024
35 checks passed
@poiana poiana deleted the refactor/support-field-modifiers branch May 8, 2024 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants