-
Notifications
You must be signed in to change notification settings - Fork 910
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update(engine): modify append_output format #3322
update(engine): modify append_output format #3322
Conversation
This PR may bring feature or behavior changes in the Falco engine and may require the engine version to be bumped. Please double check userspace/engine/falco_engine_version.h file. See versioning for FALCO_ENGINE_VERSION. /hold |
LGTM label has been added. Git tree hash: b99934e0070d45b144746852aa90bea53118a345
|
/milestone 0.39.0 |
@@ -501,9 +502,18 @@ void rule_loader::compiler::compile_rule_infos( | |||
continue; | |||
} | |||
|
|||
if (extra.m_tag != "" && r.tags.count(extra.m_tag) == 0) | |||
if (extra.m_tags.size() != 0) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Exctract an helper method since the same check is also used below?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed by using a single function instead.
I think we need to update configuration.cpp json schema too! |
@FedeDP damn I forgot 🤣 , will fix. thanks |
Good catch! side topic: it would be nice to introduce some automatic check |
There is an automatic check that loads the falco.yaml from the CMAKE_CURRENT_SOURCE_DIR; but in this case, the new option is not present by default in the Falco yaml thus the test passes fine. |
Signed-off-by: Luca Guerra <[email protected]>
Signed-off-by: Luca Guerra <[email protected]>
91413c8
to
02308b3
Compare
Signed-off-by: Luca Guerra <[email protected]>
… make sense Signed-off-by: Luca Guerra <[email protected]>
6c02aad
to
957bb62
Compare
LGTM label has been added. Git tree hash: bbfa0e0fffbcc70350dbb99b7dd9aa25d4774125
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: FedeDP, LucaGuerra The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/unhold |
What type of PR is this?
/kind feature
Any specific area of the project related to this PR?
/area engine
What this PR does / why we need it:
Having discussed this feature with @leogr and @Issif we came to the conclusion that it could be better to modify the format of
append_output
to something like this example:tags
,source
,rule
are ANDed together and also when multiple tags are specified those are all ANDed together as well.Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: