-
Notifications
You must be signed in to change notification settings - Fork 912
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update(build): relax dkms dependencies to suggestions in DEB and RPM packages #3450
Conversation
Running in modern_ebpf mode does not require kernel build dependencies Signed-off-by: John Thiltges <[email protected]>
Welcome @jthiltges! It looks like this is your first PR to falcosecurity/falco 🎉 |
Hi! Thanks for this PR! This is something on our mind since ~1yr, but we couldn't find the time to work on it. /cc @leogr @LucaGuerra |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi! Thanks for this PR! Indeed, we would love to improve Falco packages by splitting them for-driver, so that one can install
falco-kmod
that would install a Falco configured to run with the kernel module driver and with all kmod deps, afalco-ebpf
and normalfalco
that would just drop all unneeded deps since it runs with modern ebpf driver.This is something on our mind since ~1yr, but we couldn't find the time to work on it. IMHO for now, this can be a good solution since the default Falco use case does not need any additional dep.
/cc @leogr @LucaGuerra
I totally agree with Fede, and I'm ok with merging this PR now, so approved! and
/milestone 0.40.0
Then the only possible issue I see is the documentation. I can then work to update the docs.
@jthiltges thank you for contribution! 🙏
LGTM label has been added. Git tree hash: 57c7e171e831387d5aa0b8c03999d1c5a71cca33
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: FedeDP, jthiltges The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Using Falco with the modern_ebpf driver does not require kernel build dependencies. This PR updates the cmake configuration to make the
dkms
andkernel-devel
package requirements into suggestions.What type of PR is this?
/kind cleanup
Any specific area of the project related to this PR?
/area build
What this PR does / why we need it:
This makes the
kernel-devel
anddkms
dependencies optional when installing thefalco
package, significantly reducing the number of packages installed when running in modern_ebpf mode.On Alma 8, installing Falco 0.39.2 from RPM requires
dkms
andkernel-devel
, which adds many dependencies for a total of 76 packages on my minimal test VM. After converting thedkms
andkernel-devel
requirements to suggestions with rpmrebuild, no additional dependencies beyondfalco
itself were required, and Falco appears to run fine with modern_ebpf. This PR should have the same effect on packages generated by cmake.Does this PR introduce a user-facing change?:
YES